feat(api): validate required app config items #2472
Conversation
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
| @@ -137,7 +137,7 @@ wait_for_pods_running() { | |||
| current_time=$(date +%s) | |||
| elapsed_time=$((current_time - start_time)) | |||
| if [ "$elapsed_time" -ge "$timeout" ]; then | |||
| kubectl get pods -A -o yaml || true | |||
| kubectl get pods -A || true | |||
| // TODO: should an item really not be required if it's hidden? | ||
| if item.Hidden || item.When == "false" { | ||
| return false | ||
| } |
There was a problem hiding this comment.
This is how KOTS works today
| configItems := make(map[string]kotsv1beta1.ConfigItem) | ||
| configChildItems := make(map[string]kotsv1beta1.ConfigChildItem) |
There was a problem hiding this comment.
ConfigItem vs. ConfigChildItem is sort of confusing. I initially thought that ConfigItem was actually a ConfigGroup. Is ConfigChildItem for select_one/dropdown type of config types?
There was a problem hiding this comment.
I am not sure. @sgalsaleh what is ConfigChildItem?
There was a problem hiding this comment.
Yes, it's for certain config item types like radio and dropdown that have multiple options to select from.
emosbaugh
force-pushed
the
emosbaugh/sc-126366/enforce-required-items-on-the-config-page
branch
from
ebe2d70 to
f4a302c
Compare
| if item.Hidden { | ||
| return false | ||
| } |
There was a problem hiding this comment.
I created a follow up story for this https://app.shortcut.com/replicated/story/126644/correct-app-config-hidden-required-behavior
| @@ -415,3 +481,241 @@ func TestKubernetesGetAppConfigValues(t *testing.T) { | |||
| assert.Equal(t, http.StatusUnauthorized, apiError.StatusCode) | |||
| }) | |||
| } | |||
|
|
|||
| // TestInstallController_SetAppConfigValuesWithAPIClient tests the SetAppConfigValues endpoint using the API client | |||
| func TestInstallController_SetAppConfigValuesWithAPIClient(t *testing.T) { | |||
There was a problem hiding this comment.
can be done in a separate pr
| func TestInstallController_SetAppConfigValuesWithAPIClient(t *testing.T) { | |
| func TestInstallController_PatchAppConfigValuesWithAPIClient(t *testing.T) { |
| @@ -414,3 +483,241 @@ func TestLinuxGetAppConfigValues(t *testing.T) { | |||
| assert.Equal(t, http.StatusUnauthorized, apiError.StatusCode) | |||
| }) | |||
| } | |||
|
|
|||
| // TestInstallController_SetAppConfigValuesWithAPIClient tests the SetAppConfigValues endpoint using the API client | |||
| func TestInstallController_SetAppConfigValuesWithAPIClient(t *testing.T) { | |||
emosbaugh
deleted the
emosbaugh/sc-126366/enforce-required-items-on-the-config-page
branch
What this PR does / why we need it:
API support and validation for required items
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?